From e24e847f4b1a9f76ec2486febe935252127d3ea1 Mon Sep 17 00:00:00 2001
From: JIIIIL <504439788@qq.com>
Date: Sun, 31 Mar 2024 20:33:17 +0800
Subject: [PATCH 1/3] misspelled word invalidates the background(SplitView
 lightDismiss)

---
 src/Semi.Avalonia/Controls/SplitView.axaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/Semi.Avalonia/Controls/SplitView.axaml b/src/Semi.Avalonia/Controls/SplitView.axaml
index 6c0e58e..78a0e77 100644
--- a/src/Semi.Avalonia/Controls/SplitView.axaml
+++ b/src/Semi.Avalonia/Controls/SplitView.axaml
@@ -235,7 +235,7 @@
             </Style>
         </Style>
 
-        <Style Selector="^:lightdismiss /template/ Rectangle#LightDismissLayer">
+        <Style Selector="^:lightDismiss /template/ Rectangle#LightDismissLayer">
             <Setter Property="Fill" Value="#99000000" />
         </Style>
         <Style Selector="^:overlay:open /template/ Rectangle#LightDismissLayer">

From 3716cc3bcca0b9f4b615177fb69983468bc49804 Mon Sep 17 00:00:00 2001
From: rabbitism <popmessiah@hotmail.com>
Date: Sun, 31 Mar 2024 21:51:01 +0800
Subject: [PATCH 2/3] feat: make sure mask is invisible in inline mode. use
 dynamic brush.

---
 src/Semi.Avalonia/Controls/SplitView.axaml     | 4 ++--
 src/Semi.Avalonia/Themes/Dark/SplitView.axaml  | 1 +
 src/Semi.Avalonia/Themes/Light/SplitView.axaml | 1 +
 3 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/Semi.Avalonia/Controls/SplitView.axaml b/src/Semi.Avalonia/Controls/SplitView.axaml
index 78a0e77..852ffc2 100644
--- a/src/Semi.Avalonia/Controls/SplitView.axaml
+++ b/src/Semi.Avalonia/Controls/SplitView.axaml
@@ -129,7 +129,7 @@
                                 x:Name="PART_ContentPresenter"
                                 Content="{TemplateBinding Content}"
                                 ContentTemplate="{TemplateBinding ContentTemplate}" />
-                            <Rectangle Name="LightDismissLayer" />
+                            <Rectangle Name="LightDismissLayer" IsVisible="False" />
                         </Panel>
 
                     </Grid>
@@ -236,7 +236,7 @@
         </Style>
 
         <Style Selector="^:lightDismiss /template/ Rectangle#LightDismissLayer">
-            <Setter Property="Fill" Value="#99000000" />
+            <Setter Property="Fill" Value="{DynamicResource SplitViewMaskBrush}" />
         </Style>
         <Style Selector="^:overlay:open /template/ Rectangle#LightDismissLayer">
             <Setter Property="IsVisible" Value="True" />
diff --git a/src/Semi.Avalonia/Themes/Dark/SplitView.axaml b/src/Semi.Avalonia/Themes/Dark/SplitView.axaml
index aea9a99..e422867 100644
--- a/src/Semi.Avalonia/Themes/Dark/SplitView.axaml
+++ b/src/Semi.Avalonia/Themes/Dark/SplitView.axaml
@@ -1,4 +1,5 @@
 <ResourceDictionary xmlns="https://github.com/avaloniaui" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml">
     <SolidColorBrush x:Key="SplitViewSeparatorBackground" Opacity="0.08" Color="#F9F9F9" />
+    <SolidColorBrush x:Key="SplitViewMaskBrush" Color="#FFA7ABB0" Opacity="0.2"></SolidColorBrush>
     <SolidColorBrush x:Key="SplitViewPaneBackground" Color="#16161A" />
 </ResourceDictionary>
\ No newline at end of file
diff --git a/src/Semi.Avalonia/Themes/Light/SplitView.axaml b/src/Semi.Avalonia/Themes/Light/SplitView.axaml
index e29053f..7733059 100644
--- a/src/Semi.Avalonia/Themes/Light/SplitView.axaml
+++ b/src/Semi.Avalonia/Themes/Light/SplitView.axaml
@@ -1,4 +1,5 @@
 <ResourceDictionary xmlns="https://github.com/avaloniaui" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml">
     <SolidColorBrush x:Key="SplitViewSeparatorBackground" Opacity="0.08" Color="#1C1F23" />
+    <SolidColorBrush x:Key="SplitViewMaskBrush" Color="#FF555B61" Opacity="0.2"></SolidColorBrush>
     <SolidColorBrush x:Key="SplitViewPaneBackground" Color="White" />
 </ResourceDictionary>
\ No newline at end of file

From 92e0362eb6b84664312c5dcfacb1d0b07d20ddb7 Mon Sep 17 00:00:00 2001
From: Dong Bin <14807942+rabbitism@users.noreply.github.com>
Date: Sun, 31 Mar 2024 23:13:24 +0800
Subject: [PATCH 3/3] Apply suggestions from code review

Co-authored-by: Zhang Dian <54255897+zdpcdt@users.noreply.github.com>
---
 src/Semi.Avalonia/Themes/Dark/SplitView.axaml  | 2 +-
 src/Semi.Avalonia/Themes/Light/SplitView.axaml | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/Semi.Avalonia/Themes/Dark/SplitView.axaml b/src/Semi.Avalonia/Themes/Dark/SplitView.axaml
index e422867..35c9a13 100644
--- a/src/Semi.Avalonia/Themes/Dark/SplitView.axaml
+++ b/src/Semi.Avalonia/Themes/Dark/SplitView.axaml
@@ -1,5 +1,5 @@
 <ResourceDictionary xmlns="https://github.com/avaloniaui" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml">
     <SolidColorBrush x:Key="SplitViewSeparatorBackground" Opacity="0.08" Color="#F9F9F9" />
-    <SolidColorBrush x:Key="SplitViewMaskBrush" Color="#FFA7ABB0" Opacity="0.2"></SolidColorBrush>
+    <SolidColorBrush x:Key="SplitViewMaskBrush" Opacity="0.2" Color="#A7ABB0" />
     <SolidColorBrush x:Key="SplitViewPaneBackground" Color="#16161A" />
 </ResourceDictionary>
\ No newline at end of file
diff --git a/src/Semi.Avalonia/Themes/Light/SplitView.axaml b/src/Semi.Avalonia/Themes/Light/SplitView.axaml
index 7733059..fc36c21 100644
--- a/src/Semi.Avalonia/Themes/Light/SplitView.axaml
+++ b/src/Semi.Avalonia/Themes/Light/SplitView.axaml
@@ -1,5 +1,5 @@
 <ResourceDictionary xmlns="https://github.com/avaloniaui" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml">
     <SolidColorBrush x:Key="SplitViewSeparatorBackground" Opacity="0.08" Color="#1C1F23" />
-    <SolidColorBrush x:Key="SplitViewMaskBrush" Color="#FF555B61" Opacity="0.2"></SolidColorBrush>
+    <SolidColorBrush x:Key="SplitViewMaskBrush" Opacity="0.2" Color="#555B61"  />
     <SolidColorBrush x:Key="SplitViewPaneBackground" Color="White" />
 </ResourceDictionary>
\ No newline at end of file